Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calbrate measurements #39

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Calbrate measurements #39

merged 3 commits into from
Dec 4, 2023

Conversation

Casper-NS
Copy link
Member

  • Calibrate measurements by subtracting the min of devices detected.
  • Removed rssi filtering.
  • Added a test for the calibration.
  • Changed everything to UTC.

Taoshix
Taoshix approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@Taoshix Taoshix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting way of using the median, i like it

@Casper-NS Casper-NS force-pushed the calibrateMeasurements branch from a9d21ed to f12c78a Compare December 4, 2023 12:00
@Casper-NS Casper-NS requested a review from mads256h December 4, 2023 12:10
Taoshix
Taoshix approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@Taoshix Taoshix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Immutable arrays, I like

@Casper-NS Casper-NS merged commit a695ee7 into master Dec 4, 2023
3 checks passed
@Casper-NS Casper-NS deleted the calibrateMeasurements branch December 4, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taoshix Taoshix Taoshix approved these changes

@mads256h mads256h Awaiting requested review from mads256h

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Casper-NS @mads256h @Taoshix